Skip to content

UbersmithException returns the original code and message given by the API #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2016
Merged

UbersmithException returns the original code and message given by the API #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/api_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,13 @@ def test_api_raises_exception_with_if_data_status_is_false(self, request_mock):
ubersmith_api = ubersmith_client.api.init(self.url, self.username, self.password)

self.expect_a_ubersmith_call(request_mock, method="client.miss", data=data)
assert_that(calling(ubersmith_api.client.miss), raises(ubersmith_client.exceptions.UbersmithException))

with self.assertRaises(ubersmith_client.exceptions.UbersmithException) as cm:
ubersmith_api.client.miss()

catched_exception = cm.exception
assert_that(catched_exception.code, equal_to(1))
assert_that(catched_exception.message, equal_to('invalid method specified: client.miss'))

@requests_mock.mock()
def test_api_raises_exception_for_invalid_status_code(self, request_mock):
Expand Down
4 changes: 2 additions & 2 deletions ubersmith_client/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def process_request(self, http_method, **kwargs):
response_json = response.json()
if not response_json['status']:
raise UbersmithException(
500,
"error {0}, {1}".format(response_json['error_code'], response_json['error_message'])
response_json['error_code'],
response_json['error_message']
)

return response.json()["data"]
Expand Down