Make sync-rsync.remotePath optional in VSCode config #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current VSCode sync-rsync extension setup involves pointing `sync-rsync.executable` at nomad/vsync, which has a shebang that sets `-e`, giving this rsync subshell the power to crash the script and not perform the nomad alloc sync portion. This would prevent that from happening in the non-petabox case.
|
Full transparency: this was a ChatGPT o3-mini-high solution–there may be a better option |
|
i can live with this. the only slight pause here is it will just continue on (w/o warning) if people are using the i wonder about either "deferring" a fail-out to the end for the WDY thinK? |
|
First one sounds simpler, and absolutely a good idea. Updated the fork, seems to work for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current VSCode sync-rsync extension setup involves pointing
sync-rsync.executableat nomad/vsync, which has a shebang that sets-e, giving this rsync subshell the power to crash the script and not perform the nomad alloc sync portion. This would prevent that from happening in the non-petabox case.