-
Notifications
You must be signed in to change notification settings - Fork 14
Add bgnpcgn-Afgn-Latn-2007 system #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@manuel489 I've updated the file and fixed some issues. Notice that not all characters can be copied and pasted, we will need to use the unicode numbers directly, sometimes multiple code points for a single character (e.g. |
|
|
Hi @ronaldtse, I'd like to make some comments:
|
Could you explain which these cases are?
The language code should be
Each source character should be implemented as a separate rule. e.g. these: # VOWELS
'ئه' / 'ه' : 'e' # See notes 1 and 5
'ئا' / 'ا' : 'a' # See note 1
'ئي' / 'ي' : 'î' # See notes 1, 6 and 7Should be implemented as: # VOWELS
'ئه' : 'e' # See notes 1 and 5
'ه' : 'e' # See notes 1 and 5
'ئا' : 'a' # See note 1
'ا' : 'a' # See note 1
'ئي' : 'î' # See notes 1, 6 and 7
'ي' : 'î' # See notes 1, 6 and 7 |
@ronaldtse, for example: |
maps/bgnpcgn-prs-Arab-Latn-2007.yaml
Outdated
| a. Initially, it indicates that the word begins with a vowel or diphthong; the alif itself is not romanized, but rather the short vowel it “carr es” is romanized; e.g., ميړ أَسَلم ژرَندَه → Mī Aslam Zhrandah | ||
| a. Initially, it indicates that the word begins with a vowel or | ||
| diphthong; the alif itself is not romanized, but rather the short vowel | ||
| it “carr es” is romanized; e.g., ميړ أَسَلم ژرَندَه → Mī Aslam Zhrandah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronaldtse, why text paragraphs must be splitted in several lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, because it reads better in the editor :-)
| - 'a' | ||
| - 'â' | ||
|
|
||
| # Both e and i are available to romanize this short vowel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for these comments to be on separate lines. In addition, comments and code lines should be separate, so that git tracks the actual change in code vs comments, instead of mixing changes for code vs comments.
0451f70 to
344b3c6
Compare
|
superseded by https://github.com/interscript/interscript/pull/441 |
From @manuel489