Skip to content

Conversation

@isc-bsaviano
Copy link
Contributor

No description provided.

isc-bsaviano and others added 2 commits November 30, 2021 10:59
Co-authored-by: John Murray <johnm@georgejames.com>
@isc-bsaviano isc-bsaviano requested a review from daimor as a code owner December 1, 2021 18:28
@isc-bsaviano isc-bsaviano marked this pull request as draft December 1, 2021 18:28
@isc-bsaviano isc-bsaviano changed the title Pepare for 1.2.0 release Prepare for 1.2.0 release Dec 1, 2021
@isc-bsaviano isc-bsaviano marked this pull request as ready for review December 2, 2021 13:27
@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray @daimor This is ready to be released today if we want to get 1.2.0 out before we adopt the pre-release mechanism

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it.

@isc-bsaviano isc-bsaviano merged commit 957012a into intersystems-community:master Dec 2, 2021
@isc-bsaviano isc-bsaviano deleted the release-1.2.0 branch December 2, 2021 15:37
@gjsjohnmurray
Copy link
Contributor

@daimor it looks like the Marketplace publish failed when CI responded to the release @isc-bsaviano created.

image

I haven't checked, but I'm guessing the part of CI which removes the proposed API stuff from package.json isn't doing the right thing with the new property which 1.63 is moving to.

@daimor
Copy link
Member

daimor commented Dec 2, 2021

I'll check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants