Update RID injection interface to support F3411-22a testing #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original RID injection interface took a shortcut by referencing many F3411-19 objects rather than creating equivalents within the interface. This made the interface specification far smaller and simpler than it would have otherwise been, but it tied the automated testing interface to F3411-19. F3411-22a has some differences from -19 that cannot be tested effectively using the -19 objects. This PR, therefore, copies the F3411-19 objects into the interface directly rather than referencing the F3411-19 standard (first commit) and then adds new data structures and fields to support F3411-22a (second commit).
These changes are intended to be fully backwards-compatible with the current interface. Technically, there is one exception in RIDAuthData where the format field changes from a string to an int, but I do not believe anyone has even looked at this part of the data structures let alone used it.