strategy defalut name should use ClassName.to_s.underscore#684
Closed
comme wants to merge 1 commit intoomniauth:masterfrom
comme:6cc4fcdc151c856a7b84ee2732f23b8af3e34213
Closed
strategy defalut name should use ClassName.to_s.underscore#684comme wants to merge 1 commit intoomniauth:masterfrom comme:6cc4fcdc151c856a7b84ee2732f23b8af3e34213
comme wants to merge 1 commit intoomniauth:masterfrom
comme:6cc4fcdc151c856a7b84ee2732f23b8af3e34213
Conversation
…ame.to_s.underscore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strategy defalut name should use ClassName.to_s.underscore,cause in my app, omniauth strategy class name is JoshId, but i don't set option :name, 'josh_id',it get strategy name is joshid not josh_id.