Add the config.session_key to override 'rack.session'#819
Add the config.session_key to override 'rack.session'#819nicoolas25 wants to merge 1 commit intoomniauth:masterfrom
Conversation
There was a problem hiding this comment.
This is not instance variable in origin code, I feel maybe there are some reason to not use instance variable (but author only knows...).
There was a problem hiding this comment.
It isn't nope. It seems to use the default attribute accessor so it basically does the same thing. I updated it for clarity and it does not break the test suite, that's good enough for me ^^
|
Since Rack isn't yet allowing you to update the I'll close it but I think the cleaning in #818 may be worth merging. |
|
I don't understand how to use this? |
Hello,
This PR allows this kind of configuration:
Maybe some of you will find it usefull as I do ^^