Resolve DeprecationWarning When Accessing Response Headers #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. A DeprecationWarning is raised when this method is called. This updated file accesses HTTPResponse.headers directly as-recommended. Tested/validated with end-of-day options API
Contributor
|
We are unable to directly merge this, but I've included it in the latest release, with proper credit in the release notes to this pull request for the associated changes. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
DeprecationWarningis raised whenHTTPResponse.getheaders()is called. The method is deprecated and will be removed inurllib3 v2.1.0.This updated file accesses
HTTPResponse.headersdirectly as-recommended.Tested/validated with end-of-day options API