NTCredentials support. #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Added NTCredentials if username contains / or \. Perhaps adding domain in proxyconfig might be better
| String port = proxyConfig.getPort(); | ||
| if (!host.isEmpty() && !port.isEmpty()) { | ||
| CredentialsProvider credentialsProvider = new BasicCredentialsProvider(); | ||
| if (username.contains("/") || username.contains("\\")) { |
Collaborator
There was a problem hiding this comment.
Instead of adding this check, let's add a new field called domain in the ProxyConfig and if domain is found lets use NTCredentials else use UsernamePasswordCredentials.
Collaborator
|
@kedarpanse - Yes, lets add domain in ProxyConfig. If you want you can send another pull request, if not i can go ahead and add it and close this one out. |
2. Added NTCredentials if domain not empty in HttpRequestClinent
Author
|
@diana-derose I see similar code on Config.java HTTPBatchClientConnectionInterceptor and HTTPClientConnectionInterceptor, should I also add domain in Config.java and update these two classes? Not sure where else it needs to be updated. Please advise. |
Collaborator
|
Yes, I'll add it there as well as in the payments SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps adding domain in proxyconfig might be better? Not sure which way would you like to go.