Extra kwargs in some function definitions?

[miggland]

If you could confirm that I'm correct in my interpretation here:

Extra kwargs, which should not be sent:

inventree-python/inventree/base.py

Line 161 in d13d8af

response = api.get(url=cls.URL, params=params, **kwargs)

since the kwargs are put in the params variable a few lines before:

inventree-python/inventree/base.py

Line 156 in d13d8af

params = kwargs

Same thing here:

inventree-python/inventree/base.py

Line 183 in d13d8af

response = api.get(url=url, params=params, **kwargs)

following on

inventree-python/inventree/base.py

Line 175 in d13d8af

params = kwargs

[SchrodingersGat]

@miggland you're right this looks strange. I think that probably params=params should be removed from all instances?

[miggland]

Hmm.. the get function for example doesn't do the translation to the params variable though.. it just forwards all kwargs.

Shouldn't eg line 183 be changed from
response = api.get(url=url, params=params, **kwargs)
to
response = api.get(url=url, params=params)

Also, the check if URL is in kwargs should be before kwargs are assigned to params, or is this required later on?

Maybe I should make a PR and test this out..