Skip to content

fix: improve exception message when firebase.json is misconfigured #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: improve exception message when firebase.json is misconfigured #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutterfire_cli/lib/src/commands/upload_symbols.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand {
appId = configurationMap[kAppId] as String?;
projectId = configurationMap[kProjectId] as String?;
} catch (e) {
throw FirebaseJsonException();
throw FirebaseJsonException(underlyingException: e.toString());
}

if (projectId == null || appId == null) {
Expand Down
5 changes: 4 additions & 1 deletion packages/flutterfire_cli/lib/src/common/strings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,12 @@ class XcodeProjectException implements FlutterFireException {

/// An exception that is thrown when you do not have a firebase.json file at the root of your project or it does not have values required
class FirebaseJsonException implements FlutterFireException {
FirebaseJsonException({this.underlyingException}) : super();

final String? underlyingException;
@override
String toString() {
return 'FirebaseJsonException: Please run "flutterfire configure" to update the `firebase.json` at the root of your Flutter project with correct values.';
return 'FirebaseJsonException: Please run "flutterfire configure" to update the `firebase.json` at the root of your Flutter project with correct values. ${underlyingException != null ? '' : underlyingException}';
}
}

Expand Down
Loading