React 0.56 support

[xzilja]

Issue

Updating to react native v0.56.0 requires flow bin update to ^0.75.0 which results in following errors

Error ┈┈┈┈┈ node_modules/react-native-firebase/dist/modules/firestore/Query.js.flow:417:20

Property fieldpath is missing in NativeFieldPath [1].

 [1]  46│   fieldPath: NativeFieldPath,
        :
     414│           fieldOrder.fieldPath.string
     415│         ) {
     416│           values.push(docSnapshot.get(fieldOrder.fieldPath.string));
     417│         } else if (fieldOrder.fieldPath.fieldpath) {
     418│           const fieldPath = new FieldPath(...fieldOrder.fieldPath.fieldpath);
     419│           values.push(docSnapshot.get(fieldPath));
     420│         }


Error ┈┈┈┈ node_modules/react-native-firebase/dist/modules/storage/reference.js.flow:77:12

Cannot return new StorageTask(...) because StorageTask [1] is incompatible with
Promise [2].

     74│    * @return {Promise}
     75│    */
 [2] 76│   downloadFile(filePath: string): Promise<Object> {
 [1] 77│     return new StorageTask(
     78│       DOWNLOAD_TASK,
     79│       getNativeModule(this._storage).downloadFile(this.path, filePath),
     80│       this
     81│     );
     82│   }
     83│
     84│   /**


Error ┈┈┈ node_modules/react-native-firebase/dist/modules/storage/reference.js.flow:100:12

Cannot return new StorageTask(...) because StorageTask [1] is incompatible with
Promise [2].

      97│    */
 [2]  98│   putFile(filePath: Object, metadata: Object = {}): Promise<Object> {
      99│     const _filePath = filePath.replace('file://', '');
 [1] 100│     return new StorageTask(
     101│       UPLOAD_TASK,
     102│       getNativeModule(this._storage).putFile(this.path, _filePath, metadata),
     103│       this
     104│     );
     105│   }
     106│ }
     107│

Environment

1. Application Target Platform: iOS

2. Development Operating System: macOS High Sierra

3. Build Tools: Not needed

4. React Native version: 0.56.0

5. React Native Firebase Version: 4.2.0

6. Firebase Module: firestore, storage

7. Are you using typescript? no

---

Loving react-native-firebase? Please consider supporting them with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[Salakar]

@iljadaderko rn 56 has backwards compatible breaking changes so support for it will only land in v5.0.0, we have started work on it in this branch already: https://github.com/invertase/react-native-firebase/tree/react-native-56

Thanks for the heads up!

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[leethree]

We already upgraded our project to React Native v0.56. Should I use the current version (v4.3.6) or wait for v5? Is there anything known to break in v4 other than flow errors (which we can ignore)?

[Salakar]

@leethree there's this issue and all the ones linked above your comment e.g. there are issues with importing and using react-native-firebase in JS land due to breaking changes in the way the module is compiled with Babel; as it has been upgraded to v7:

Support will land in v5 in the next week or two hopefully.

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[leethree]

@Salakar got it! we'll probably wait for v5 if it's coming soon.

[smkhalsa]

@Salakar any idea when v5 will land?

[Salakar]

@smkhalsa hey; we're aiming for a release on the 7th. Thanks