Skip to content

Conversation

@rlemasquerier
Copy link
Contributor

Description

The dynamic links workaround on iOS applying [RNFBDynamicLinksAppDelegateInterceptor sharedInstance]; in didFinishLaunchingWithOptions is not properly injected when used along @react-native-firebase/app expo plugin because the header tag is the same.

Related issues

Related to #4548 (comment) as it allows to use with expo the given workaround mentioned by the doc

Release Summary

fix dynamic-links expo plugin

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 11, 2022 at 11:18PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Nov 11, 2022 at 11:18PM (UTC)

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thank you!

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #6688 (d246b9c) into main (fe9e404) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6688   +/-   ##
=========================================
  Coverage     54.06%   54.06%           
  Complexity      690      690           
=========================================
  Files           216      216           
  Lines         10773    10773           
  Branches       1696     1696           
=========================================
  Hits           5823     5823           
  Misses         4658     4658           
  Partials        292      292           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants