Skip to content

chore: example test app for users to run. Initialised VertexAi example #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

chore: example test app for users to run. Initialised VertexAi example #8471

merged 5 commits into from
Apr 16, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Apr 15, 2025 •
edited
Loading

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Apr 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 2:11pm

@russellwheatley russellwheatley changed the title test: create a test app for users to run test: create an example test app for users to run. Initialised vertexai example Apr 15, 2025
@russellwheatley russellwheatley changed the title test: create an example test app for users to run. Initialised vertexai example tests: Example test app for users to run. Initialised vertexai example Apr 15, 2025
@russellwheatley russellwheatley changed the title tests: Example test app for users to run. Initialised vertexai example test(vertexai): Example test app for users to run. Initialised vertexai example Apr 15, 2025
@russellwheatley russellwheatley changed the title test(vertexai): Example test app for users to run. Initialised vertexai example chore: Example test app for users to run. Initialised VertexAi example Apr 16, 2025
@russellwheatley russellwheatley changed the title chore: Example test app for users to run. Initialised VertexAi example chore: example test app for users to run. Initialised VertexAi example Apr 16, 2025
@russellwheatley russellwheatley marked this pull request as ready for review April 16, 2025 09:38
mikehardy
mikehardy requested changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one suggestion on the iOS startup line or we may take SIGSEGVs on startup, plus a perf tweak while in there

runs okay from my local pull+check though 👍

russellwheatley and others added 2 commits April 16, 2025 15:04
@russellwheatley @mikehardy
Update package.json
cc66916 
Co-authored-by: Mike Hardy <github@mikehardy.net>
@russellwheatley
Update README.md
be64ca1
mikehardy
mikehardy approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one - great hack with bundler config to reuse e2e app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 16, 2025
@russellwheatley russellwheatley merged commit c26253c into main Apr 16, 2025
15 of 17 checks passed
@russellwheatley russellwheatley deleted the vertexai-example branch April 16, 2025 16:18
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

@MichaelVerdon MichaelVerdon MichaelVerdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@russellwheatley @mikehardy @MichaelVerdon