Skip to content

destroy and create logic fix for custom segments #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

destroy and create logic fix for custom segments #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions lib/src/main/java/com/otaliastudios/transcoder/internal/CustomSegments.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class CustomSegments(

private val log = Logger("Segments")
private var currentSegment: Segment? = null
private var currentSegmentMapKey: String? = null
val currentIndex = mutableTrackMapOf(-1, -1)
private val segmentMap = mutableMapOf<String, Segment?>()

Expand All @@ -43,14 +44,15 @@ class CustomSegments(

fun getSegment(id: String): Segment? {
return segmentMap.getOrPut(id) {
destroySegment(id)
destroySegment()
tryCreateSegment(id).also {
currentSegment = it
currentSegmentMapKey = id
}
}
}

fun release() = destroySegment()
fun release() = destroySegment(true)

private fun tryCreateSegment(id: String): Segment? {
val index = sources[TrackType.VIDEO].indexOfFirst { it.mediaId() == id }
Expand All @@ -74,19 +76,19 @@ class CustomSegments(
return Segment(TrackType.VIDEO, index, pipeline)
}

private fun destroySegment(id: String? = null) {
private fun destroySegment(releaseAll: Boolean = false) {
currentSegment?.let {
it.release()
val source = sources[it.type][it.index]
if (tracks.active.has(it.type)) {
source.releaseTrack(it.type)
}
}
if (id == null) {
segmentMap.clear()
}
else {
segmentMap[id] = null
currentSegmentMapKey?.let {
segmentMap[it] = null
}
if(releaseAll) {
segmentMap.clear()
}
}
}
private fun DataSource.init() = if (!isInitialized) initialize() else Unit
Expand Down