Skip to content

Conversation

@psychedelicious
Copy link
Contributor

@psychedelicious psychedelicious commented Oct 20, 2022

Adds base: '', to vite config.

The resultant change in the build frontend is that asset paths are relative instead of absolute, e.g.:

<link rel="stylesheet" href="/assets/index.58175ea1.css"> ==> <link rel="stylesheet" href="./assets/index.556a5ea7.css">

I believe hope this resolves #1159 and shouldn't affect anything else.

@psychedelicious psychedelicious marked this pull request as draft October 20, 2022 13:15
@psychedelicious
Copy link
Contributor Author

I've converted this to a draft, pending @steverweber reviewing.

@psychedelicious psychedelicious marked this pull request as ready for review October 20, 2022 15:11
@blessedcoolant
Copy link
Collaborator

Seems fine. Just double check with the docs here once: https://socket.io/docs/v4/client-options/

It seems the only requirement is that the client and server side pathname should always remain the same.

@psychedelicious
Copy link
Contributor Author

@blessedcoolant , I made another change and got this working for the requester, and both normal and dev servers still work fine. Can you please test this and re-review the changes?

@psychedelicious
Copy link
Contributor Author

The default server path is the same, and we aren't specifying it, so I suppose we are all clear.

@steverweber
Copy link

regarding socket.io "The server and the client values must match (unless you are using a path-rewriting proxy in between)." in the issue case there's a proxy.

@lstein lstein merged commit 71a1e0d into invoke-ai:development Oct 25, 2022
@psychedelicious psychedelicious deleted the vite-relative-paths branch October 25, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants