Bugfix/reenable ckpt conversion to ram #2868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
JPPhoto,
blessedcoolant,
damian0815,
hipsterusername and
keturn
as code owners
JPPhoto
suggested changes
Mar 5, 2023
There was a problem hiding this comment.
This code fails when moving a file from diffusers to hub:
NotADirectoryError: [Errno 20] Not a directory:
PosixPath('/home/jsp/InvokeAI/models/diffusers/6b24dfca04e9eb5e308587eb12feb6c18adafbd90d21974ccf5b4bb17f2b4190.a8a930da
e638521a74d7ad5f62383f034387cc398c567adcead8c7e7366f67cc.json')
The error is thrown because migrate_models in model_manager.py tries to remove a directory but this is a file. The file doesn't appear to be moved properly, either.
I've fixed this on # 2867 and tested with a variety of directories, files and symlinks. |
JPPhoto
approved these changes
Mar 5, 2023
blessedcoolant
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash that was occurring when trying to load a legacy checkpoint file.
Note that this PR includes commits from #2867 to avoid diffusers files from re-downloading at startup time.