Skip to content

Conversation

ebr
Copy link
Member

@ebr ebr commented Mar 26, 2023

FastAPI is broken on main (17d8bbf) - any request returns a 500 type error.

This PR downgrades fastapi and related packages again. I wish I had a better solution, but this at least fixes the immediate breakage.

Fixes #3038

@ebr ebr requested a review from Kyle0654 March 26, 2023 06:57
@psychedelicious
Copy link
Collaborator

On Linux, I also need to revert to an earlier fastapi version. I haven't attempted to bisect the version to identify the latest that still works, so I've also just rolled back to 0.85.0 as it works fine.

@Kyle0654
Copy link
Contributor

Do you mind finding which version is broken and on what platform and why? These versions together are all working for me, and I stepped them all back from latest until I had a working combination. I feel like there's something from FastAPI that I actually needed to upgrade for too (though I can't remember what... Possibly related to schemas).

@Kyle0654
Copy link
Contributor

Put another way, could you find the latest version of FastAPI that does work?

@ebr ebr force-pushed the downgrade-fastapi branch from 840800d to 2b03241 Compare March 29, 2023 02:08
@ebr
Copy link
Member Author

ebr commented Mar 29, 2023

@Kyle0654 I stepped through versions, and the latest one that does work is 0.88.0. I updated the PR accordingly. Didn't need to downgrade uvicorn actually either.

As for "why" - I spent some time on this, but couldn't figure out the root cause. interestingly, the KeyError in the stack trace references different Invocation types seemingly at random.

@ebr ebr enabled auto-merge (rebase) March 29, 2023 02:44
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ebr ebr merged commit cc5687f into invoke-ai:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: FastAPI is broken in main

4 participants