Skip to content

Conversation

SammCheese
Copy link
Contributor

Occasionally you may find yourself wanting to use the WebUI in public (remotely?) but not showing everyone what you last generated, or generating something without wanting others to see it.
While you could disable "Display In-Progress Images" it will still show you the final image, which might not be something a user wants.

This PR attempts to solve that problem by adding a button to toggle visibility of the Preview.
For the Image2Image tab, it hides both the uploaded image and the preview

image
image

@blessedcoolant
Copy link
Collaborator

Rest of it seems fine. Thanks for the PR. I'll let @psychedelicious also give a quick glance before we build and merge.

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I've got a small nitpick: hidden is not super descriptive of the variable. I'd prefer something like shouldHidePreviews.

Can you please choose a more descriptive name, and add a chore(ui): build commit after running yarn build (we have to bundle the build in the repo, long story)?

Thanks for your contribution!

@SammCheese
Copy link
Contributor Author

This should do ^^

@blessedcoolant
Copy link
Collaborator

blessedcoolant commented Apr 15, 2023

This should do ^^

You didn't update the setter function's name yet. Also can you check why your build has changes to other localization stuff? Seems to be removing and adding a ton of other strings.

@SammCheese SammCheese changed the title feat: Add "Hide Preview" Button to WebUI feat(ui): Add "Hide Preview" Button to WebUI Apr 15, 2023
@SammCheese
Copy link
Contributor Author

SammCheese commented Apr 15, 2023

This should do ^^

You didn't update the setter function's name yet. Also can you check why your build has changes to other localization stuff? Seems to be removing and adding a ton of other strings.

That's odd. I didn't change anything regarding localization. I just ran yarn build as requested by psychedelicious.

@blessedcoolant
Copy link
Collaborator

That's odd. I didn't change anything regarding localization. I just ran yarn build as requested by psychedelicious.

Just checked again. Seems like those might be left overs from earlier PR's that weren't built yet. Don't worry about it. Change the setter function's name to match the new variable name and build again. Should be good to go after that.

@blessedcoolant blessedcoolant self-requested a review April 15, 2023 07:35
@psychedelicious psychedelicious merged commit 50eb02f into invoke-ai:main Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants