-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(ui): Add "Hide Preview" Button to WebUI #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rest of it seems fine. Thanks for the PR. I'll let @psychedelicious also give a quick glance before we build and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I've got a small nitpick: hidden
is not super descriptive of the variable. I'd prefer something like shouldHidePreviews
.
Can you please choose a more descriptive name, and add a chore(ui): build
commit after running yarn build
(we have to bundle the build in the repo, long story)?
Thanks for your contribution!
This should do ^^ |
You didn't update the setter function's name yet. Also can you check why your build has changes to other localization stuff? Seems to be removing and adding a ton of other strings. |
That's odd. I didn't change anything regarding localization. I just ran |
Just checked again. Seems like those might be left overs from earlier PR's that weren't built yet. Don't worry about it. Change the setter function's name to match the new variable name and build again. Should be good to go after that. |
Occasionally you may find yourself wanting to use the WebUI in public (remotely?) but not showing everyone what you last generated, or generating something without wanting others to see it.
While you could disable "Display In-Progress Images" it will still show you the final image, which might not be something a user wants.
This PR attempts to solve that problem by adding a button to toggle visibility of the Preview.
For the Image2Image tab, it hides both the uploaded image and the preview