Skip to content

Conversation

psychedelicious
Copy link
Collaborator

  • this resize/scale latents is what is needed for hires fix
  • also remove unused seed from t2l

@psychedelicious psychedelicious force-pushed the feat/nodes/resize-scale-latents branch from 0ee9ccb to df89176 Compare April 26, 2023 11:50
@psychedelicious
Copy link
Collaborator Author

@Kyle0654 request your review on this

Copy link
Contributor

@Kyle0654 Kyle0654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to mark as approved, but I think someone with more experience with latents should comment here - I don't know how correct this is or if it'll work as expected. My major comment is about parameters - I think expecting the user to know what they're doing is okay here, and we should just expect them to provide target width/height for the latent.

@psychedelicious
Copy link
Collaborator Author

@Kyle0654 Thanks for reviewing.

Generally, this does work as expected (did a lot of testing, creates awesome hires fix outputs, and decoding the resized latents immediately gives you some interesting visuals for the different interpolation settings).

@psychedelicious psychedelicious enabled auto-merge (rebase) April 27, 2023 23:20
@psychedelicious psychedelicious merged commit 4a924c9 into main Apr 27, 2023
@psychedelicious psychedelicious deleted the feat/nodes/resize-scale-latents branch April 27, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants