-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add compel node and conditioning field type #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Works as advertised. But I think we need to change a few things unrelated to this PR.
|
thanks, looks good. not sure the latents storage is the right place to put the embeddings tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments about usability. Try using it in the CLI to validate usability =)
Functionality is good. But why did you merge both Positive and Negative conditioning into the same output? I think they should both be outputted as individual outputs so they can be plugged as needed across multiple nodes if need be. |
Done as I said in title, but need to test(and understand) how cli works, as previously it uses single prompt and now it's positive and negative.