Skip to content

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented May 2, 2023

migrate canvas to nodes

many changes across the UI and some changes to nodes backend

nodes

  • image upload route accepts an image type. this way we can upload the intermediate canvas images (eg the canvas and its mask which are used for img2img) as intermediates
  • make seed optional w/ default factory to generate random seeds
  • add infill nodes (that's as far as I've gotten with porting the generator Inpaint class over to nodes)
  • add ColorField (supporting solid infill method)
  • add ImageToLatentsInvocation (VAE Encode)
  • improve choose_model logic and messaging
  • fix the types in inpaint.py in an effort to make sense of it

ui

well there's a ton. major points:

  • redux-persist --> redux-remember. modern, maintained, but not very popular for whatever reason. lovely code.
  • use RTK createListenerMiddleware to handle coordinating the more complex workflows for canvas
  • migrate canvas over to nodes (seam paint regression in [bug]: seam painting regression #3361, missing inpaint width/height params - once canvas backend is fully nodified i will fix this up)
  • refactor param components (no more accordions - self-contained modular collapsibles, paves the way for an eventual customizable UI setup)
  • refactor tab layouts
  • gallery infinite scroll w/ virtualized list (windowing) for performance
  • scrollbars! (ya they need tweaking but thats OK for now)
  • progress image UI improvements
  • many many many bug fixes

one major regression. the responsive design was impossible to keep intact as i went through all these substantial changes. once things settle a bit (after we have controlnet UI figured out basically) i will work on it.

edit: in-canvas progress images are tricky and not yet implemented

@psychedelicious psychedelicious force-pushed the feat/ui/nodes-canvas branch 5 times, most recently from c22d5bc to 263adb1 Compare May 10, 2023 13:54
@psychedelicious psychedelicious marked this pull request as ready for review May 10, 2023 13:54
@psychedelicious
Copy link
Collaborator Author

i see the metadata test is failing. i'll fix that tomorrow.

Copy link
Contributor

@Kyle0654 Kyle0654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes probably needed, but don't want my review to hold you up.

- `progress_images` is no longer a parameter
- `seamless` needs to be reworked as a model config, removed as a param
@psychedelicious psychedelicious merged commit e0d6946 into main May 11, 2023
@psychedelicious psychedelicious deleted the feat/ui/nodes-canvas branch May 11, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants