-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ui: migrate canvas to nodes #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c22d5bc
to
263adb1
Compare
1 task
i see the metadata test is failing. i'll fix that tomorrow. |
This reverts commit 99cb33f.
until we have a better system for metadata, this will remain half-baked
- Mainly an issue for commercial due to incomplete metadata handling
263adb1
to
4035304
Compare
Kyle0654
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes probably needed, but don't want my review to hold you up.
1 task
blessedcoolant
approved these changes
May 11, 2023
- `progress_images` is no longer a parameter - `seamless` needs to be reworked as a model config, removed as a param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate canvas to nodes
many changes across the UI and some changes to nodes backend
nodes
ColorField
(supporting solid infill method)ImageToLatentsInvocation
(VAE Encode)choose_model
logic and messaginginpaint.py
in an effort to make sense of itui
well there's a ton. major points:
redux-persist
-->redux-remember
. modern, maintained, but not very popular for whatever reason. lovely code.createListenerMiddleware
to handle coordinating the more complex workflows for canvasone major regression. the responsive design was impossible to keep intact as i went through all these substantial changes. once things settle a bit (after we have controlnet UI figured out basically) i will work on it.
edit: in-canvas progress images are tricky and not yet implemented