Make InvocationProcessor more robust against exceptions #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested changes
May 10, 2023
psychedelicious
approved these changes
May 10, 2023
ebr
force-pushed
the
queue-soft-lock
branch
2 times, most recently
from
9a3f776 to
f7480b1
Compare
1. if retrieving an item from the queue raises an exception, the InvocationProcessor thread crashes, but the API continues running in a non-functional state. This fixes the issue 2. when there are no items in the queue, sleep 1 second before checking again. 3. Also ensures the thread isn't crashed if an exception is raised from invoker, and emits the error event Intentionally using base Exceptions because for now we don't know which specific exception to expect. Fixes (sort of)? invoke-ai#3222
blessedcoolant
approved these changes
May 12, 2023
Kyle0654
approved these changes
May 12, 2023
ebr
commented
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvocationProcessorthread crashes, but the API continues running in a non-functional state. This fixes the issueIntentionally using base
Exceptions here because for now we don't know which specific exception to expect. We can refine this in the future.Fixes (sort of)? #3222