fix(nodes): fix seam painting #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
GreggHelt2,
JPPhoto,
blessedcoolant,
damian0815 and
lstein
as code owners
JPPhoto
approved these changes
May 23, 2023
blessedcoolant
approved these changes
May 23, 2023
1 task
psychedelicious
force-pushed
the
feat/nodes/fix-seam-painting
branch
2 times, most recently
from
fe3ddea to
9d06e98
Compare
The problem was the same seed was getting used for the seam painting pass, causing the fried look. Same issue as if you do img2img on a txt2img with the same seed/prompt. Thanks to @hipsterusername for teaming up to debug this. We got pretty deep into the weeds.
psychedelicious
force-pushed
the
feat/nodes/fix-seam-painting
branch
from
9d06e98 to
d2996be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was the same seed was getting used for the seam painting pass, causing the fried look.
Same issue as if you do img2img on a txt2img with the same seed/prompt.
Thanks to @hipsterusername for teaming up to debug this. We got pretty deep into the weeds.