Skip to content

misc fixes #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 29, 2023
Merged

misc fixes #3479

merged 15 commits into from
May 29, 2023

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented May 29, 2023 •
edited
Loading

@psychedelicious
fix(ui): fix auto-switch to new images
f62bb41
@psychedelicious
fix(ui): infill and scaling options label
d215e98
@psychedelicious
fix(ui): fix save to gallery without bounding box
233444d
@psychedelicious
fix(ui): add additional socket event layer to gate handling socket ev…
0867d29 
…ents

Some socket events should not be handled by the slice reducers. For example generation progress should not be handled for a canceled session.

Added another layer of socket actions.

Example:
- `socketGeneratorProgress` is dispatched when the actual socket event is received
- Listener middleware exclusively handles this event and determines if the application should also handle it
- If so, it dispatches `appSocketGeneratorProgress`, which the slices can handle

Needed to fix issues related to canceling invocations.
@psychedelicious
fix(ui): when session is complete, null out progress image
0b4f09e 
This may cause minor gallery jumpiness at the very end of processing, but is necessary to prevent the progress image from sticking around if the last node in a session did not have an image output.
@psychedelicious
feat(nodes): add resize image and scale image nodes
b6904f5
@psychedelicious
fix(ui): typo
7713496
@psychedelicious
feat(ui): revert in-gallery progress
5c46f9e 
wasn't fully baked. will revisist in the future.
@psychedelicious
fix(ui): fix progress images in canvas
1c54841
@psychedelicious
fix(ui): fix typo in actionsDenylist
6794628
@psychedelicious
feat(ui): cancel session when staging image accepted
134a0fe
@psychedelicious
feat(ui): only cancel on staging commit if processing
ceb629a
@psychedelicious
feat(ui): gallery filter dropdown -> Images/Assets toggle
b0ec818
@psychedelicious
fix(ui): remove console.log()
59e73b0
@psychedelicious
feat(ui): add progress image toggle to current image buttons
f56b927
@psychedelicious psychedelicious marked this pull request as ready for review May 29, 2023 12:51
@hipsterusername hipsterusername merged commit 070218a into main May 29, 2023
@hipsterusername hipsterusername deleted the fix/misc-fixes branch May 29, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@Kyle0654 Kyle0654 Awaiting requested review from Kyle0654

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psychedelicious @hipsterusername