ui: improve metadata handling #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
psychedelicious
commented
May 31, 2023
psychedelicious
commented
- feat(ui): refactor parameter recall
- use zod to validate parameters before recalling
- update recall params hook to handle all validation and UI feedback
- fix(ui): do not allow dpmpp_2s to be used ever
- it doesn't work for the img2img pipelines, but the implemented conditional display could break the scheduler selection dropdown.
- simple fix until diffusers merges the fix - never use this scheduler.
- use zod to validate parameters before recalling - update recall params hook to handle all validation and UI feedback
it doesn't work for the img2img pipelines, but the implemented conditional display could break the scheduler selection dropdown. simple fix until diffusers merges the fix - never use this scheduler.
maryhipp
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.