-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Make Invoke Button also the progress bar #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Find on some screens the progress bar at top of screen gets cut off
It's neat. What about when the parameters panel is hidden? |
Okay. I like it. I'll let @psychedelicious chime in and we merge. |
One small change, can we make sure there's no UI shift? Right now the elements move. I think setting the progress bar to absolute overlay might work better. In this case it might not be a huge deal coz the button goes inactive when in progress so theres no user interactivity anyway but ideally we want to avoid layout shifts. |
Hmm,I'm not sold. I don't mind changing the progress indicator, but the proposed change causes layout shifts which we should avoid. Can you explain the problem with the current placement in a bit more detail? An alternative to the invoke button's bottom edge might be using a CSS gradient to "fill up" the invoke button as progress increases. |
I like the gradient idea better. |
on the screen resolution I use and the zoom level the current progress bar is very small |
@mickr777 @psychedelicious I pushed a new button style. Please give it a try and see how it feels. firefox_m81RZN2zEj.mp4firefox_8rNEeiBpLg.mp4 |
that is what I was trying to aim for, but my knowledge isn't there, so could only get it how I did |
All good. I just built upon what you did. I like it. If @psychedelicious thinks its good enough, we'll go for a merge. |
maybe it should be added to the node blend button edit: nvm your already on that as I was typing |
Just how we roll. Haha. But yeah, added a temporary full component copy button for it. We'll probably generalize the Invoke button at some stage so we can reuse the component. But can worry about that when doing the Nodes UI. |
Find on some screens the progress bar at top is hard to see, Bar should only show when in progress