Maryhipp/delete images on board #3604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
Kyle0654,
blessedcoolant and
psychedelicious
as code owners
psychedelicious
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
I'm approving and merging, but suggesting some future changes for boards:
board_image_records.get_images_for_board()could be reduced in scope to only retrieve the junction table rows - so no join needed - and just get a list of image names, instead of full records. This wasn't a function you added, just thought about it reading through.- We could probably just have a single delete board modal that has a checkbox to disable all images in the board. When we refactor the singleton modals we can take care of this.
psychedelicious
force-pushed
the
maryhipp/delete-images-on-board
branch
from
0c30087 to
5324234
Compare
blessedcoolant
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.