Detect invalid model names when migrating 2.3->3.0 #3623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
GreggHelt2,
JPPhoto,
StAlKeR7779,
blessedcoolant and
damian0815
as code owners
blessedcoolant
approved these changes
Jul 2, 2023
…g model name keys
psychedelicious
force-pushed
the
lstein/fix-imported-model-names
branch
from
37496c8 to
307a01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user discovered that 2.3 models whose symbolic names contain the "/" character are not imported properly by the
migrate-models-3script. This fixes the issue by changing "/" to underscore at import time.