-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Rewrite controlnet to new model manager #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added the controlnet field to node editor, and your draft does seem to work fine. One thing we want to do is associate controlnet models to processors - like canny model defaults to canny preprocessor. I think this association should probably be in the frontend, rather than introducing a new concept to the backend. Any thoughts or concerns there? Once we decide how to proceed with that, I can get the linear UI controlnet updated. |
Any resolution on this decision point? |
Just pushed up some changes for linear workflow - @psychedelicious I actually couldn't figure out how your node implementation was working (I couldn't get network calls to trigger and it seems to use some phantom list of constants that I can't find in the code), so I'm sorry if I broke it. My changes:
|
69b4558
to
69ac89c
Compare
feat(ui): fix controlNet models
|
This PR is good to go. Maybe just changing the assertion of the control_weight to take values up to 2 instead of 1 and updating the linear UI slider to be 0, 1, 2 with 1 as default. But I'll let @psychedelicious @GreggHelt2 make the final call on that one. Everything else seems to be working fine. Great job guys. Oh .. the annotator models download to HF cache on first load. Maybe this should be handled by the installer? |
86a3dc8
to
e58c14f
Compare
…. add disabled state if base model is not compatible. clear control net model if main base model changes. add logic to guess processor and move it up in UI
- update controlnet state to use object format for model - update model-parsing helper functions to log errors - update nodes components, types and state - remove controlnets from state when models are loaded and the controlnet's model is not available
…ectors makes them more portable and easier to reason about
…disabled The UX is clearer now, but it's still easy to miss that your individual controlnets are enabled, but the overall controlnet feature is disabled.
It is the most impactful feature, and also takes up the most space when you expand it. Promoted.
0493e2f
to
457e4b7
Compare
needed to have their label styles match chakras
093fb64
to
8e0ba24
Compare
Screen.Recording.2023-07-15.at.8.49.50.pm.mov |
No description provided.