Skip to content

feat: Add Clip Skip #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 7, 2023
Merged

feat: Add Clip Skip #3666

merged 7 commits into from
Jul 7, 2023

Conversation

StAlKeR7779
Copy link
Contributor

No description provided.

@blessedcoolant blessedcoolant requested a review from maryhipp as a code owner July 6, 2023 17:57
@blessedcoolant
Copy link
Collaborator

Added Clip Skip to Linear UI.

New Setting:

  • Show Advanced Options --> Enable this to show Advanced Options accordion.
  • Inside this is Clip Skip.
  • Works on Text2img, img2img, canvas (all modes)

@blessedcoolant blessedcoolant changed the title Add clip skip option to prompt node feat: Add Clip Skip Jul 6, 2023
@psychedelicious
Copy link
Collaborator

@StAlKeR7779
Between iterations/graphs (i.e. between loading of clip), is it reset?

I mean, let's say we skip=1 for one graph. On the next graph, we omit the ClipSkipInvocation entirely. Is skip=1 or skip=0 on this next graph?

@blessedcoolant blessedcoolant enabled auto-merge July 7, 2023 04:22
@blessedcoolant blessedcoolant merged commit 7481508 into main Jul 7, 2023
@blessedcoolant blessedcoolant deleted the feat/clip_skip branch July 7, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant blessedcoolant approved these changes

@damian0815 damian0815 Awaiting requested review from damian0815

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@JPPhoto JPPhoto Awaiting requested review from JPPhoto

@GreggHelt2 GreggHelt2 Awaiting requested review from GreggHelt2

@Kyle0654 Kyle0654 Awaiting requested review from Kyle0654

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StAlKeR7779 @blessedcoolant @psychedelicious