UI model compatibiltiy #3672
Merged
UI model compatibiltiy #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
force-pushed
the
maryhipp/compatible-models
branch
from
a238249 to
37cf2da
Compare
|
Nah we'll just leave prompt as-is, I've made rule that we do not attempt to parse the prompt - will lead us to pain. I've updated the PR with some changes, ready for review. |
psychedelicious
approved these changes
Jul 7, 2023
psychedelicious
force-pushed
the
maryhipp/compatible-models
branch
from
37cf2da to
123b741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all submodels are compatible with selected base_model
Note: since adding a textual inversion embedding updates the prompt itself, I'm not sure its worth trying to unparse that from the string