gallery tweaks #3682
Merged
gallery tweaks #3682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
commented
Jul 7, 2023
invokeai/frontend/web/src/features/gallery/components/ImageGalleryContent.tsx
Outdated
Show resolved
Hide resolved
maryhipp
changed the title
psychedelicious
force-pushed
the
maryhipp/gallery-tweaks
branch
from
5aba2c3 to
f79a3bd
Compare
|
feat(ui): fill up gallery on app start taking the coward's way out on this and just fetching 100 images & 100 assets on app start...
|
psychedelicious
approved these changes
Jul 7, 2023
psychedelicious
force-pushed
the
maryhipp/gallery-tweaks
branch
from
f79a3bd to
4aee975
Compare
psychedelicious
force-pushed
the
maryhipp/gallery-tweaks
branch
from
5781508 to
38df613
Compare
taking the coward's way out on this and just fetching 100 images & 100 assets on app start... - add `appStarted` action, dispatched once on mount in App.tsx. listener fetches 100 images & 100 assets - fix bug with selectedBoardId & assets tab
…t for initial fetch
Just made it a spinner, getting it to be styled correctly otherwise is a pain
- `isLoading` - now `true` *only* on first load - added `isFetching` - `true` whenever gallery images are fetching - on first load, show a spinner instead of skeletons. this prevents an awkward flash of skeletons into empty gallery when the gallery doesn't have enough images to fill it. - removed `imageCategoriesChanged` listener, bc now on app start, both images and assets will be populated. leaving this in caused jank flashes of skeletons when switching gallery tabs when gallery doesn't have images to load
psychedelicious
force-pushed
the
maryhipp/gallery-tweaks
branch
from
38df613 to
9450a2b
Compare
|
@blessedcoolant mind giving this one a go? try with no db to emulate new user experience
|
|
@psychedelicious Tested all mentioned conditions. Seems good. Couldn't find any obvious bugs. |
blessedcoolant
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.