ui, db: rand fixes #3715
Merged
ui, db: rand fixes #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the selector itself being memoized, the gallery was rerendering on every progress image.
This was rerendering on every progress image, now it doesn't
It wasn't disabled when it should have been, looked clickable during generation.
This is extraneous; the `board_images` table holds image-board relationships.
psychedelicious
requested review from
Kyle0654,
blessedcoolant and
maryhipp
as code owners
blessedcoolant
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): memoize ImageContextMenu selector
Without the selector itself being memoized, the gallery was rerendering on every progress image.
feat(ui): memoize NextPrevImageButtons component
This was rerendering on every progress image, now it doesn't
fix(ui): correctly set disabled on invoke button during generation
It wasn't disabled when it should have been, looked clickable during generation.
fix(nodes): remove board_id column from images table
This is extraneous; the
board_imagestable holds image-board relationships. @maryhipp