Add defaults for controlnet/textual inversion/realesrgan #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
GreggHelt2,
JPPhoto,
StAlKeR7779,
blessedcoolant,
damian0815 and
ebr
as code owners
psychedelicious
requested review from
Kyle0654,
brandonrising and
maryhipp
as code owners
- remove restoration services - remove the restore faces nodes - update tests
psychedelicious
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
Thanks Lincoln, I've added and tested a RealESRGAN upscaling node, works great.
We can fully remove the restoration services now, they are not needed. I've removed all references to them in the nodes app layer and updated the tests.
It's just the backend that has the actual restoration code - I'll leave that to you to remove.
|
@maryhipp @brandonrising @ebr
It also introduces an upscaling node, which is not yet exposed in the Linear UI. I'll add that later. |
|
I've removed all the backend restoration code and will merge. |
|
I've added a couple small fixes:
|
blessedcoolant
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several default models to the ones selected at install time. It also removes the GFPGAN and text2clip models, which should shave a little time off the install process.
ESRGAN:
ControlNet
Embedding (textual inversion)