-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Model Manager UI 3.0 #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Manager UI 3.0 #3778
Conversation
Going to rework the whole thing. The old system is convoluted and too difficult to plug back.
For reusability
Will be needed when we implement changing name and base model type.
Just played with the UI, and tested adding, deleting and updating a model (didn't test merge). I note that when you type in a Civitae model URL into Import Models it does import correctly. Another thing to be aware of is that you can provide the URL/path/repo_id of any kind of model, including controlnet, LoRA and embedding, and so it might be useful to expand the row of buttons to show these installed models as well. |
@lstein Model Rename is failing for models in the InvokeAI root folder. Works fine when the path is custom. The error: |
I've fixed this crash. However there is an issue that emerges when the update and rename operations are combined. Let's say that you decide to rename "foo" to "foobar". The original configuration looked like this:
You decide to change foo's name to "foobar", and pass this body:
Notice that the path is still ending with "foo" rather than the new name "foobar". What should the update code do? Should it rename the model path to "foobar", or should it honor the assigned path in the body? Currently what happens is wrong. The path is renamed to "foobar" and then the entry in models.yaml is updated to the old path. |
I think the path should remain untouched. Coz I can have a model that got added as "foobar_v2" .. but I renamed it to foobar.. I think the path should be irrelevant. If a user wants to change that, then they manually move the folder and update the path accordingly. Coz I am not a fan of changing folder name coz what if another folder exists? We just error out and giving that feedback would be hard. So i feel it should remain untouched. Maybe @hipsterusername has some thoughts on it. |
Implemented. External paths (outside of the invokeai models directory) can be updated. Internal paths cannot. |
To be explicit (I had only responded via reaction in Discord) - I think this is a good path. Do we have any blockers on merging in? Think this has been thoroughly tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!!
- Now inside ScrollArea - Now displays installed models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yolo
This PR completely ports over the Model Manager to 3.0 -- all of the functionality has now been restored in addition to the following changes.
This is a wrap for this PR.
TODO: (Probably for 3.1)