install, nodes, ui: restore ad-hoc upscaling #3800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
GreggHelt2,
Kyle0654,
StAlKeR7779,
blessedcoolant,
brandonrising,
damian0815,
lstein and
maryhipp
as code owners
|
I've renamed the node |
lstein
approved these changes
Jul 17, 2023
- add `RealESRGAN_x2plus.pth` model to installer - add `RealESRGAN_x2plus.pth` to `realesrgan` node - rename `RealESRGAN` to `ESRGAN` in nodes - make `scale_factor` optional in `img_scale` node
- remove face restoration entirely - add dropdown for ESRGAN model select - add ad-hoc upscaling graph and workflow
psychedelicious
force-pushed
the
feat/ui/upscale
branch
from
b3fd29e to
416afd2
Compare
|
Fixed tests, forgot to change something when I renamed a node |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opted to leave out any additional upscaling parameters like scale and denoising strength, which, from my review of the ESRGAN code, don't do much:
If there is demand, we can implement output size/scale UI and handle it by passing the upscaled image to that a resize/scale node.
I also understand we previously had some functionality to blend the upscaled image with the original. If that is desired, we would need to implement that as a node that we can pass the upscaled image to.
Demo:
Screen.Recording.2023-07-17.at.9.22.01.pm.mov
feat(nodes): add RealESRGAN_x2plus.pth, update upscale nodes
RealESRGAN_x2plus.pthmodel to installer @lsteinRealESRGAN_x2plus.pthtorealesrgannodeRealESRGANtoESRGANin nodesscale_factoroptional inimg_scalenodefeat(ui): restore ad-hoc upscaling