feat: Add Sync Models #3850
Merged
feat: Add Sync Models #3850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
Kyle0654,
blessedcoolant,
brandonrising and
psychedelicious
as code owners
psychedelicious
requested changes
Jul 20, 2023
There was a problem hiding this comment.
Small nit pick change requested - but this is good, it allows the UI to automatically refresh all model lists.
For context, the UI is using a network fetching and caching library that supports tags for cache invalidation. What we can do is say "when this mutation occurs, invalidate the caches for all fetched model lists" and it just automagically happens
Co-authored-by: psychedelicious <4822129+psychedelicious@users.noreply.github.com>
blessedcoolant
changed the title
psychedelicious
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
This changes the "sync" route from a GET to POST method, in keeping with the Representational Existential(?) State Transfer (REST) protocol.