Fix incorrect use of a singleton list #3914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zopieux
requested review from
GreggHelt2,
Kyle0654,
StAlKeR7779,
blessedcoolant,
brandonrising,
damian0815,
lstein and
psychedelicious
as code owners
Contributor
|
There are a lot of opportunities to improve the types in the model manager and its routers - thanks for taking care of this one. I dream of a successful mypy run in the future... If you have any questions about this area of the code, you can ping @StAlKeR7779 or @lstein. |
psychedelicious
approved these changes
Jul 23, 2023
Contributor
Author
Lots of low-hanging fruits already being surfaced by VS Code pylance integration, but I will refrain from fixing those until the codebase enables some formatter. It's too cumbersome right now. Thanks for the quick review! |
This was found through pylance type errors. Go types!
blessedcoolant
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
search_for_modelsis explicitly typed as taking a singularPathbut was given a list because some later function in the stack expects a list. Fixed that to be compatible with the paths. This is the only use of that function.The
list()call is unrelated but removes a type warning since it's supposed to return a list, not a set. I can revert it if requested.This was found through pylance type errors. Go types!