feat: ✨ consolidated app nav to settings & dropdown #4000
Conversation
joshistoast
requested review from
blessedcoolant,
maryhipp and
psychedelicious
as code owners
|
There's currently an issue where sometimes the localized language variable doesn't resolve properly and results in the original raw string:
|
Most likely an issue with hot reload at times. Refreshing the page should fix it. |
|
Pushed a couple of fixes.
Everything else seems fine to me. I'll let @psychedelicious have a quick look too before we merge. Thanks for the PR. |
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
overall looks good just a few changes needed
invokeai/frontend/web/src/features/system/components/SiteHeader.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/system/components/SiteHeader.tsx
Outdated
Show resolved
Hide resolved
|
Can we please leave the ColorModeButton as an unused exported component for now? |
Any reason to keep it around? |
maryhipp
left a comment
maryhipp
left a comment
There was a problem hiding this comment.
Found a workaround for colormode export - LGTM
These needs to be done through weblate. Only en.json needs to updated via the repo
exposes more menu theming config
feat(ui) use `as` for menuitem links I had requested this be done with the chakra `Link` component, but actually using `as` is correct according to the docs. For other components, you are supposed to use `Link` but looks like `MenuItem` has this built in. Fixed in all places where we use it. Also: - fix github icon - give menu hamburger button padding - add menu motion props so it animates the same as other menus feat(ui): restore ColorModeButton @maryhipp chore(ui): lint feat(ui): remove colormodebutton again sry
4 participants
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Moves all the application's top right nav elements into a new hamburger menu or into the settings modal.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?