Refactor generate.py and dream.py #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lstein
commented
Sep 13, 2022
lstein
commented
- Moved handling of the models.yaml configuration file into the Generate() object. This simplifies the logic in dream.py and makes the symbolic model naming system available to other scripts that use generate.py
- Removed multiple dangling variables in generate.py that were either never used, or were redundant.
- Simplified the handling of keyboard interrupts between dream.py and generate.py
- Tweaked the output of ddim.py a bit to make progress reporting more attractive.
- Moved scripts/inpaint.py into scripts/orig_scripts/inpaint.py in order to discourage people from using this nonfunctional script.
* config file path (models.yaml) is parsed inside Generate() to simplify API * Better handling of keyboard interrupts in file loading mode vs interactive * Removed oodles of unused variables.
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 19, 2022
* revert inadvertent change of conda env name (invoke-ai#528) * Refactor generate.py and dream.py * config file path (models.yaml) is parsed inside Generate() to simplify API * Better handling of keyboard interrupts in file loading mode vs interactive * Removed oodles of unused variables. * move nonfunctional inpainting out of the scripts directory * fix ugly ddim tqdm formatting
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 19, 2022
* revert inadvertent change of conda env name (invoke-ai#528) * Refactor generate.py and dream.py * config file path (models.yaml) is parsed inside Generate() to simplify API * Better handling of keyboard interrupts in file loading mode vs interactive * Removed oodles of unused variables. * move nonfunctional inpainting out of the scripts directory * fix ugly ddim tqdm formatting
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 21, 2022
* revert inadvertent change of conda env name (invoke-ai#528) * Refactor generate.py and dream.py * config file path (models.yaml) is parsed inside Generate() to simplify API * Better handling of keyboard interrupts in file loading mode vs interactive * Removed oodles of unused variables. * move nonfunctional inpainting out of the scripts directory * fix ugly ddim tqdm formatting
austinbrown34
pushed a commit
to cognidesign/InvokeAI
that referenced
this pull request
Dec 30, 2022
* revert inadvertent change of conda env name (invoke-ai#528) * Refactor generate.py and dream.py * config file path (models.yaml) is parsed inside Generate() to simplify API * Better handling of keyboard interrupts in file loading mode vs interactive * Removed oodles of unused variables. * move nonfunctional inpainting out of the scripts directory * fix ugly ddim tqdm formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.