Skip to content

Conversation

@Malrama
Copy link
Contributor

@Malrama Malrama commented Dec 23, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because I don't think this is needed

Have you updated all relevant documentation?

  • Yes
  • No, not needed

Description

This commit updates Torch to the last stable release of 2.1.2 and xformers to its compatible version 0.0.23post1. No regressions accrued so far.
This is most likely the last stable release before PyTorch 2.2 is released. Brace yourself for some discord issues about torch running on CPU only. This happens, when people use the updater and pip is updating torch using the non-cuda version. I don't know if this has since changed (I think I saw a commit that changed something about that). I always use the installer to update, which ensures that the correct PyTorch version is chosen.

Regardless, this should be safe to be merged.

Merry Christmas, dear developers! I hope you have a wonderful time with your friends and family, and thank you for all your making this wonderful piece of software <3

Greetings

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy holidays!

@Millu Millu enabled auto-merge (squash) December 26, 2023 06:43
@Millu Millu merged commit f51bb00 into invoke-ai:main Dec 26, 2023
@Malrama Malrama deleted the update-torch-xformers branch January 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants