fix(mm): directory path leakage on scan folder error #8641
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
blessedcoolant,
hipsterusername and
psychedelicious
as code owners
Collaborator
|
Working as intended. |
blessedcoolant
approved these changes
Oct 27, 2025
blessedcoolant
deleted the
lstein/bugfix/scanfolders-directory-leakage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug in which private directory paths on the host could be leaked to the user interface. The error occurs during the
scan_foldersoperation when a subdirectory is not accessible. The UI shows a permission denied error message, followed by the path of the offending directory. This patch limits the error message to the error type only and does not give further details.Related Issues / Discussions
This bug was reported in a private DM on the Discord server.
QA Instructions
Before applying this PR, go to Model Manager -> Add Model -> Scan Folder and enter the path of a directory that has subdirectories that the backend should not have access to, for example
/etc. Press the Scan Folder button. You will see a Permission Denied error message that gives away the path of the first inaccesislbe subdirectory.After applying this PR, you will see just the Permission Denied error without details.
Merge Plan
Merge when approved.
Checklist
What's Newcopy (if doing a release after this PR)