Improve !fetch, add !replay command #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow save fetched commands to a file Replay command to get commands from file inside of interactive prompt Related to invoke-ai#871
lstein
requested changes
Oct 3, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
This is a nice feature. Could I ask you to make a few minor modifications?
- Extend the syntax of the !fetch command so that you can specify the file to write the prompt commands out to. If the file is not specified, you can default to
commands.txtas you do now. - Before each command in
commands.txtwould it be possible to create a#commentthat indicates the name of the file that the following command was extracted from? - Document the extended
!fetchand!replaycommands indocs/features/CLI.md - If you are brave, add
!replayto the autocomplete commands inldm/dream/readline.py
Thanks!
-- !fetch takes second optional argument name of the file to save commands to
Contributor
Author
|
Requested changes was implemented, but on Windows I could not see effects of autocomplete commands |
lstein
approved these changes
Oct 21, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
I'm approving this, but there are a few conflicts that need to be resolved. I will try to do so today.
lstein
added a commit
that referenced
this pull request
Oct 21, 2022
- This merges PR #882 Coauthor: ArDiouscuros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow save fetched commands to a file and using wildcards
Keep the same behavior if just one file is selected
Replay command to get commands from file inside of interactive prompt
Related to #871
E.g.
dream> !fetch outputs\selected-imgs*.png
Edit the commands file adjust the parameters
dream> !replay outputs\selected-imgs\commands.txt
...