Make build script handling more flexible #23
Conversation
| await this.spawnAndAwaitOutput('npm', ['run', 'watch:ts', '--', '--preserveWatchOutput'], this.rootDir, 'Watching for', { shell: true }); | ||
| await this.spawnAndAwaitOutput('npm', ['run', 'watch:ts' /*, '--', '--preserveWatchOutput'*/], this.rootDir, /watching (files )?for/i, { shell: true }); |
There was a problem hiding this comment.
Why was the preserveWatchOutput flag necessary? Since I'm using esbuild (estrella), this causes errors, but I didn't see any downside to disabling it.
Maybe we should make the scripts, their flags and the test regexp/string configurable.
There was a problem hiding this comment.
The problem with watch:ts using tsc was that it would clear the screen with every build. Since we are "forwarding" stdout from watch:ts, this would clear the screen every time, thus we would not be able to see all other logs anymore.
UncleSamSwiss
left a comment
UncleSamSwiss
left a comment
There was a problem hiding this comment.
Thanks for your PR. Everything looks good.
I will remove the "clear screen" ANSI escape sequence and no longer use the --preserveWatchOutput command line argument for watch:ts
**Breaking Change:** it is no longer possible to use `dev-server` without providing a command. Use `dev-server run` for the same behavior as before. Made build script handling more flexible (#23) Added support for different profiles (#39) Added possibility to create a backup (#28) Added possibility to restore a backup file during `dev-server setup` (#28) Added automatic installation of adapter dependencies (#8) Added version check when starting dev-server Added option to specify the ioBroker.admin version to use
2 participants
This PR makes the build script handling a bit more flexible than it currently is. In detail:
watch:reactscript as an alternative towatch:parcel(I want to get rid of parcel some time in the future)I've also edited tsconfig to force LF in the generated files.