Skip to content

Conversation

@GermanBluefox
Copy link
Contributor

@UncleSamSwiss Could you check the PR?

@GermanBluefox GermanBluefox requested a review from Copilot January 21, 2025 21:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 18 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • .npmignore: Language not supported
  • .prettierignore: Language not supported
  • LICENSE: Language not supported
  • package.json: Language not supported
  • .eslintrc.js: Evaluated as low risk
  • .prettierrc.js: Evaluated as low risk
  • README.md: Evaluated as low risk
Comments suppressed due to low confidence (3)

src/index.ts:310

  • The word 'Invaid' is misspelled. It should be 'Invalid'.
throw new Error(`Invaid profile name: "${profileName}", it may only contain a-z, 0-9, _ and -.`);

src/index.ts:730

  • [nitpick] The error message should be more clear. Suggested change: 'Failed to handle WebSocket message: ${error as Error}'.
this.log.error(`Couldn't handle WebSocket message: ${error as Error}`);

src/index.ts:1469

  • [nitpick] The variable name 'filename' should be consistently named 'fileName' to match other instances.
const verifyFile = async (filename: string, command: string, allowStar: boolean): Promise<void> => {

@UncleSamSwiss UncleSamSwiss self-requested a review January 24, 2025 07:02
UncleSamSwiss and others added 3 commits January 24, 2025 08:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@UncleSamSwiss UncleSamSwiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big update. LGTM.
I added some minor styling to the readme.

@UncleSamSwiss UncleSamSwiss merged commit 91cffef into main Jan 24, 2025
5 checks passed
@UncleSamSwiss UncleSamSwiss deleted the update-packages branch January 24, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants