rm design custom #1575
Merged
rm design custom #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
foxriver76
commented
Dec 5, 2021
foxriver76
commented
- closes Remove _design/custom from controller with 4.0 #1359
- closes #1359
foxriver76
force-pushed
the
master
branch
2 times, most recently
from
4b5f0fe to
50522ed
Compare
Contributor
|
Where design/custom is now declared? Actually I wanted to remove it from all adapters and let the declaration to be only here |
Collaborator
|
But we could simply update all adapters to remove it on their side and add jscontroller 3.3 as dep the we can also remove it here |
Collaborator
Author
|
As we have already discussed, we have a duplicate definition, we want adapters to use |
Contributor
|
Ok. Understand. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.