[feature]: Refactor common-db and common logic
#2772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t content - to allow ESM and avoid additional fixer run
- common-db is now the package for the database packages - common is now the general package
Apollon77
approved these changes
May 28, 2024
…nto common-package-refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const inst: ioBroker.InstanceObject | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.adapter.admin.0' | ||
| ); | ||
| const inst: ioBroker.InstanceObject | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const adptr: ioBroker.AdapterObject | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.adapter.admin' | ||
| ); | ||
| const adptr: ioBroker.AdapterObject | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const group: ioBroker.GroupObject | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.group.admin.faz' | ||
| ); | ||
| const group: ioBroker.GroupObject | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const config: (ioBroker.OtherObject & { type: 'config' }) | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.certificates' | ||
| ); | ||
| const config: (ioBroker.OtherObject & { type: 'config' }) | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const sysConfig: ioBroker.SystemConfigObject | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.config' | ||
| ); | ||
| const sysConfig: ioBroker.SystemConfigObject | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const systemRepo: ioBroker.RepositoryObject | null | undefined = await adapter.getForeignObjectAsync( | ||
| 'system.repositories' | ||
| ); | ||
| const systemRepo: ioBroker.RepositoryObject | null | undefined = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the feature issue which is closed by this PR
This allows us to export zipFiles etc by tools while still using db types
Implementation details
swapped the logic of common packages
Tests
Documentation
If no tests added, please specify why it was not possible
Refactor it is already tested implicitly