Skip to content

Made Result type to access status/value easier #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

Made Result type to access status/value easier #6

merged 1 commit into from
May 22, 2017

Conversation

MitalAshok
Copy link
Contributor

The new Result type removes the need for the global VALUE_IDX and STATUS_IDX variables. The type is a subclass of tuple, and can still be accessed by index, so this change is backwards compatible.

It also has the cleaner representation of Result(status='Ok', value='val') as opposed to ('Ok', 'val').

@coveralls
Copy link

coveralls commented May 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 76820b0 on MitalAshok:namedtuple-type into 2a61860 on iodevs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 76820b0 on MitalAshok:namedtuple-type into 2a61860 on iodevs:master.

@s-m-i-t-a s-m-i-t-a self-requested a review May 22, 2017 07:25
@s-m-i-t-a
Copy link
Contributor

Thanks a ton @MitalAshok . I really appreciate this.

@s-m-i-t-a s-m-i-t-a merged commit 84816d4 into iodevs:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-m-i-t-a s-m-i-t-a s-m-i-t-a approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MitalAshok @coveralls @s-m-i-t-a