Adjust tests to support Python 3.4. #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for http://bugs.python.org/issue13831 broke our tests. Monkey-patch it out so that we can still see the original problem.
Owner
|
Thanks, it's merged. ... seems Github can't detect the rebase. |
Contributor
Author
|
Thanks for your adjustments. Can I suggest using 'sys.version >= "3.4"' or similar rather than the exact-version test? Presumably 3.5 will have a similar issue, and it would be good not to leave time-bombs around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for http://bugs.python.org/issue13831 broke our tests.
Monkey-patch it out so that we can still see the original problem.